Including PUAs no longer works#1585
Open
ryan-esty wants to merge 1 commit intoCisco-Talos:mainfrom
Open
Conversation
In cli_chkpua when looking for the cat in pua_cats in strstr the parameters are backwards. Before it was looking for pua_cats in cat and failing. Found by enabling debug and seeing when I asked for specific PUAs they were skipped: ./obj-x86_64-linux-gnu/clamscan/clamscan --debug --detect-pua --include-pua=PUA.Pdf.Exploit --include-pua=PUA.Pdf.Trojan mypdf.pdf > out.txt 2>&1 out.txt grep PUA.Pdf out.txt |grep Skipping LibClamAV debug: Skipping PUA signature PUA.Pdf.Trojan.OpenActionObjectwithJavascript-1 - excluded category .Pdf.Trojan. LibClamAV debug: Skipping PUA signature PUA.Pdf.Trojan.OpenActionObjectwithJS-1 - excluded category .Pdf.Trojan. LibClamAV debug: Skipping PUA signature PUA.Pdf.Trojan.CVE_2013_0622-1 - excluded category .Pdf.Trojan. LibClamAV debug: Skipping PUA signature PUA.Pdf.Trojan.EmbeddedFile-1 - excluded category .Pdf.Trojan. LibClamAV debug: cli_loadldb: Skipping PUA signature PUA.Pdf.Trojan.EmbeddedFile-1 LibClamAV debug: Skipping PUA signature PUA.Pdf.Exploit.CVE_2013_0624-4255860-2 - excluded category .Pdf.Exploit. LibClamAV debug: cli_loadldb: Skipping PUA signature PUA.Pdf.Exploit.CVE_2013_0624-4255860-2 After the fix ./obj-x86_64-linux-gnu/clamscan/clamscan --debug --detect-pua --include-pua=PUA.Pdf.Exploit --include-pua=PUA.Pdf.Trojan mypdf.pdf > out.txt 2>&1 out.txt grep PUA.Pdf out.txt |grep Skipping # doesn't return anything
Contributor
|
Thank you for the bug fix. I will review this next week. I am presently preparing to publish the 1.5.0 early next week and won't be able to test and merge this until after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cli_chkpua when looking for the cat in pua_cats in strstr the parameters are backwards. Before it was looking for pua_cats in cat and failing.
Found by enabling debug and seeing when I asked for specific PUAs they were skipped: ./obj-x86_64-linux-gnu/clamscan/clamscan --debug --detect-pua --include-pua=Pdf.Trojan --include-pua=Pdf.Exploit mypdf.pdf > out.txt 2>&1 out.txt; grep PUA.Pdf out.txt |grep Skipping
LibClamAV debug: Skipping PUA signature PUA.Pdf.Trojan.OpenActionObjectwithJavascript-1 - excluded category .Pdf.Trojan. LibClamAV debug: Skipping PUA signature PUA.Pdf.Trojan.OpenActionObjectwithJS-1 - excluded category .Pdf.Trojan. LibClamAV debug: Skipping PUA signature PUA.Pdf.Trojan.CVE_2013_0622-1 - excluded category .Pdf.Trojan. LibClamAV debug: Skipping PUA signature PUA.Pdf.Trojan.EmbeddedFile-1 - excluded category .Pdf.Trojan. LibClamAV debug: cli_loadldb: Skipping PUA signature PUA.Pdf.Trojan.EmbeddedFile-1 LibClamAV debug: Skipping PUA signature PUA.Pdf.Exploit.CVE_2013_0624-4255860-2 - excluded category .Pdf.Exploit. LibClamAV debug: cli_loadldb: Skipping PUA signature PUA.Pdf.Exploit.CVE_2013_0624-4255860-2
After the fix
./obj-x86_64-linux-gnu/clamscan/clamscan --debug --detect-pua --include-pua=Pdf.Trojan --include-pua=Pdf.Exploit mypdf.pdf > out.txt 2>&1 out.txt; grep PUA.Pdf out.txt |grep Skipping # doesn't return anything